Use metal-toolbox version of flashrom #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshalman
force-pushed
the
flashrom-from-source
branch
3 times, most recently
from
febbd98
to
fd1ddd8
Compare
stephen-fox
approved these changes
Jan 4, 2024
| @@ -86,6 +98,9 @@ RUN microdnf install -y --setopt=tsflags=nodocs --setopt=install_weak_deps=0 \ | |||
|
|
|||
| RUN pip install uefi_firmware==v1.11 | |||
|
|
|||
| # Install our custom flashrom package | |||
| COPY --from=flashrom /root/rpmbuild/RPMS/x86_64/flashrom*.rpm /tmp | |||
| RUN rpm -ivh /tmp/flashrom*.rpm | |||
There was a problem hiding this comment.
I recall back in CentOS that using yum install /path/to/rpm was preferable to using rpm -i... it probably does not matter here, but it is something to think about.
There was a problem hiding this comment.
I was unable to figure out how to get microdnf to install from a local file. Suggestions welcome.
nshalman
force-pushed
the
flashrom-from-source
branch
from
fd1ddd8
to
627d866
Compare
nshalman
changed the title
Signed-off-by: Nahum Shalman <nshalman@equinix.com>
nshalman
force-pushed
the
flashrom-from-source
branch
from
627d866
to
4c4287a
Compare
DoctorVin
approved these changes
Jan 11, 2024
mmlb
referenced
this pull request
in metal-toolbox/vogelkop
Jun 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/metal-toolbox/ironlib](https://togithub.com/metal-toolbox/ironlib) | `v0.2.12` -> `v0.2.17` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>metal-toolbox/ironlib (github.com/metal-toolbox/ironlib)</summary> ### [`v0.2.17`](https://togithub.com/metal-toolbox/ironlib/releases/tag/v0.2.17) [Compare Source](https://togithub.com/metal-toolbox/ironlib/compare/v0.2.16...v0.2.17) #### What's Changed - Only ship flashrom on x86\_64 for now by [@​nshalman](https://togithub.com/nshalman) in [https://github.com/metal-toolbox/ironlib/pull/122](https://togithub.com/metal-toolbox/ironlib/pull/122) **Full Changelog**: metal-toolbox/ironlib@v0.2.16...v0.2.17 ### [`v0.2.16`](https://togithub.com/metal-toolbox/ironlib/releases/tag/v0.2.16) [Compare Source](https://togithub.com/metal-toolbox/ironlib/compare/v0.2.15...v0.2.16) #### What's Changed - Use metal-toolbox version of flashrom by [@​nshalman](https://togithub.com/nshalman) in [https://github.com/metal-toolbox/ironlib/pull/121](https://togithub.com/metal-toolbox/ironlib/pull/121) #### New Contributors - [@​nshalman](https://togithub.com/nshalman) made their first contribution in [https://github.com/metal-toolbox/ironlib/pull/121](https://togithub.com/metal-toolbox/ironlib/pull/121) **Full Changelog**: metal-toolbox/ironlib@v0.2.15...v0.2.16 ### [`v0.2.15`](https://togithub.com/metal-toolbox/ironlib/releases/tag/v0.2.15) [Compare Source](https://togithub.com/metal-toolbox/ironlib/compare/v0.2.14...v0.2.15) #### What's Changed - Vc/logo uefi image hash by [@​DoctorVin](https://togithub.com/DoctorVin) in [https://github.com/metal-toolbox/ironlib/pull/120](https://togithub.com/metal-toolbox/ironlib/pull/120) #### New Contributors - [@​DoctorVin](https://togithub.com/DoctorVin) made their first contribution in [https://github.com/metal-toolbox/ironlib/pull/120](https://togithub.com/metal-toolbox/ironlib/pull/120) **Full Changelog**: metal-toolbox/ironlib@v0.2.14...v0.2.15 ### [`v0.2.14`](https://togithub.com/metal-toolbox/ironlib/releases/tag/v0.2.14) [Compare Source](https://togithub.com/metal-toolbox/ironlib/compare/v0.2.13...v0.2.14) #### What's Changed - Dockerfile: install alma minimal updates by [@​joelrebel](https://togithub.com/joelrebel) in [https://github.com/metal-toolbox/ironlib/pull/117](https://togithub.com/metal-toolbox/ironlib/pull/117) **Full Changelog**: metal-toolbox/ironlib@v0.2.13...v0.2.14 ### [`v0.2.13`](https://togithub.com/metal-toolbox/ironlib/releases/tag/v0.2.13) [Compare Source](https://togithub.com/metal-toolbox/ironlib/compare/v0.2.12...v0.2.13) #### What's Changed - Dockerfile: Restate ARG TARGETOS TARGETARCH after FROM almalinux by [@​splaspood](https://togithub.com/splaspood) in [https://github.com/metal-toolbox/ironlib/pull/114](https://togithub.com/metal-toolbox/ironlib/pull/114) **Full Changelog**: metal-toolbox/ironlib@v0.2.12...v0.2.13 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/metal-toolbox/vogelkop). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Use https://github.com/metal-toolbox/flashrom/releases/tag/v1.3.99
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
How can this change be tested by a PR reviewer?
Test if the newer flashrom binary works better.
Description for changelog/release notes
Updated flashrom with patches from metal-toolbox